possibly use cached taxize objects for test suite?

[sckott]

This might be a bit tricky, but I guess whenever there's a new version of taxize on cran, then we can re-create the cached objects from taxize - then the test suite here won't fail due to failures in taxize (a lot of failures happen in taxize due to one or more of the many web services being down)

thoughts @arendsee ?

[sckott]

related to 1031a57

[arendsee]

That sounds reasonable. Also caching would speed up running the tests, which are pretty slow right now. Another nice thing about caching is that we can specify exactly what version of taxize we are testing against, and it won't slip around on us and break mysteriously.

[sckott]

Right - we can use my pkg vcr eventually, but for now we can do it manually

[arendsee]

@sckott I played a little with this. I'm a worried that it would become messy and hard to maintain, though.

This

expect_equal
  taxizedb::children("asdfasdf", db='ncbi'),
  taxize::children("asdfasdf", db='ncbi')
)

is a lot clearer than this

expect_equal(
  taxizedb::children("asdfasdf", db='ncbi'),
  readRDS("test123.Rda")
)

Can you think of a cleaner approach?

[sckott]

here's a vcr example 9fa5420 on a diff. branch

but i'm still working on some bugs (See https://github.com/ropensci/vcr/milestone/1) - if i can get it to cran soon then we can use it

[maelle]

unarchiving it thanks to @stitam 😸