Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release to CRAN? #43

Closed
zkamvar opened this issue May 13, 2021 · 18 comments
Closed

Release to CRAN? #43

zkamvar opened this issue May 13, 2021 · 18 comments
Labels
question Further information is requested

Comments

@zkamvar
Copy link
Member

zkamvar commented May 13, 2021

I think one of the things that was preventing us from releasing {tinkr} on CRAN previously was the format loss of brackets and tables. But now that we have those, I'm wondering if we should release it on CRAN (where the only thing that would prevent us from doing so is BDR). What features should we have before a CRAN release?

@zkamvar zkamvar added the question Further information is requested label May 13, 2021
@zkamvar
Copy link
Member Author

zkamvar commented May 13, 2021

Part of my motivation for this is also that we bump the version so that {pegboard} can accurately state its dependency because right now, it's causing {pegboard} to fail because the dependency check only inspects version, which in turn is bleeding into some of my alpha testing

@maelle
Copy link
Member

maelle commented May 14, 2021

We could also bump the version right away if that helps!

But yes, I do not think there's any reason not to submit to CRAN. From the currently opened issues, are there some you'd want us to tackle before the submission?

@maelle
Copy link
Member

maelle commented May 14, 2021

Maybe #36 🤔

@zkamvar
Copy link
Member Author

zkamvar commented May 14, 2021

Good point! I completely forgot about the fact that the documentation is ahem minimal 😅

@maelle maelle self-assigned this May 17, 2021
@maelle
Copy link
Member

maelle commented May 17, 2021

Actually, should we open an rOpenSci pre-submission inquiry first? It might fit as data munging.

@maelle
Copy link
Member

maelle commented May 17, 2021

(but it might also be seen as an R Markdown extension, in which case it wouldn't fit)

@zkamvar
Copy link
Member Author

zkamvar commented May 18, 2021

Actually, should we open an rOpenSci pre-submission inquiry first? It might fit as data munging.

I think that's a good idea! I think this certainly fits within the realm of data munging since that's one of the very first things I did with it! https://carpentries.github.io/pegboard/articles/swc-survey

@maelle
Copy link
Member

maelle commented May 24, 2021

Noting that one thing I'll need to to before an actual submission is re-using (Rmd fragments) the README content for a vignette.

@etiennebacher
Copy link

Hello, I use tinkr as dependency in a package (thanks for this package, it's been super helpful!) which means that I can't submit to CRAN because tinkr is not on CRAN. Do you have some plans to submit it in the coming weeks?

@zkamvar
Copy link
Member Author

zkamvar commented Mar 21, 2022

Hi @etiennebacher, I think I can get something out by early-mid April. I'm finishing up some things before my vacation next week and then I can send out the package as-is to CRAN.

My only hesitation is that #61 (which is minor, but still frustrating) and #48 are still pending changes. #48 is of particular concern because will be a major change and will force all packages using {tinkr} with {xml2} (e.g https://carpentries.github.io/pegboard/) to change the way it uses XPATH for queries.

@maelle maelle removed their assignment Mar 22, 2022
@etiennebacher
Copy link

Hello, I was wondering if there are any news about this. I don't want to look like too much insistent on this, just want to know if we can expect {tinkr} to be on cran in the next weeks/months. I quickly took a look at #48 but I don't think I can help on this.

@zkamvar
Copy link
Member Author

zkamvar commented May 14, 2022

Hi @etiennebacher, thank you for the reminder!

I'm sorry for the delay. I'll do my best to send it out in the next two weeks. I will reference this issue when I submit.

@etiennebacher
Copy link

Hi, just a small bump to know if this package will be submitted to CRAN soon

@zkamvar
Copy link
Member Author

zkamvar commented Aug 8, 2022

Thank you for the bump and sorry again for not getting to this. We've had a confluence of things come up that have put non-essential tasks on hold (see: https://carpentries.org/blog/2022/07/dovetail-005/), but I'll do a quiet submission and work on new features later.

@etiennebacher
Copy link

Thank you, actually I temporarily removed my tinkr dependency (by stealing some of your code) so there's no rush for me anymore. I understand this is not a priority.

@zkamvar
Copy link
Member Author

zkamvar commented Aug 9, 2022

I've submitted it with #73. Let's hope it passes the scrutiny of the cran team

@etiennebacher
Copy link

Hi, I just wanted to thank you for releasing on CRAN

@zkamvar
Copy link
Member Author

zkamvar commented Sep 1, 2022

No problem! Thank you for your patience and reminders!

@zkamvar zkamvar closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants