-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cran release 010 #73
cran release 010 #73
Conversation
Got some feedback:
A lot of this is not relevant to {tinkr} (e.g description and vignette) and I have no clue why they got inserted, but some of this is (using non-exported functions in help documentation to document those functions), but it oddly points to the wrong documentation file. I think the tests point is legit, though, so I'll have a looksee. |
Here is an example of a test file that does not follow the normal tempfile conventions: tinkr/tests/testthat/test-to_md.R Lines 25 to 27 in d933001
|
Response from CRAN:
|
- ignore several files in .Rbuildignore - move stylesheets to specific `stylesheets/` folder - update code to reflect change
Note: I'm going to merge this because, while it is not complete, I got the following comment from Uwe:
And of course this URL will be valid once it is merged into main. So I'm going |
This PR will be merged once tinkr is released on CRAN