Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre_release(): combine all NEWS items from previous development releases #97

Closed
krlmlr opened this issue May 16, 2021 · 17 comments · Fixed by #686
Closed

pre_release(): combine all NEWS items from previous development releases #97

krlmlr opened this issue May 16, 2021 · 17 comments · Fixed by #686

Comments

@krlmlr
Copy link
Contributor

krlmlr commented May 16, 2021

automatically, keep a # 1.6.0.9999 header to ensure that it is still edited.

@krlmlr krlmlr added this to the 0.2.0 milestone Jul 25, 2021
@maelle
Copy link
Member

maelle commented Apr 21, 2022

Seems related to #147, and useful

@krlmlr
Copy link
Contributor Author

krlmlr commented May 12, 2022

If conventional commits (#145) are used, we would also distribute the NEWS items under second-level headings.

@krlmlr krlmlr modified the milestones: 0.2.0, 0.1.1 May 12, 2022
@maelle
Copy link
Member

maelle commented May 12, 2022

and order them

@maelle
Copy link
Member

maelle commented May 16, 2022

Also

  • remove "Same as previous version."
  • If there's any other item, remove "Internal changes only."?

@maelle
Copy link
Member

maelle commented May 19, 2022

For this and conventional commit parsing, should fledge take a dependency on https://github.com/ropensci/tinkr/? 😇 With tinkr one can do Markdown to XML, XML wrangling (with xml2), XML back to Markdown.

@maelle
Copy link
Member

maelle commented May 19, 2022

(tinkr should get on CRAN soon-ish ropensci/tinkr#43 (comment))

@maelle
Copy link
Member

maelle commented May 19, 2022

another thing that's needed is parsing of the version headers.

  • it should work with the same syntaxes as what pkgdown supports (so h1 or h2, with/without the package name).
  • it should be able to strip the date, hopefully the data is always at the end between parentheses.
  • it should be able to assess what version numbers are dev ones (4 components).

@krlmlr
Copy link
Contributor Author

krlmlr commented May 19, 2022

Should this discussion and decision be part of #331, turning that issue into a blocker here?

@krlmlr
Copy link
Contributor Author

krlmlr commented May 19, 2022

This and many many other issues will be much easier with #331.

@krlmlr krlmlr modified the milestones: 0.1.1, 0.2.0 May 19, 2022
@zkamvar
Copy link
Contributor

zkamvar commented Aug 19, 2022

(tinkr should get on CRAN soon-ish ropensci/tinkr#43 (comment))

soon-ish is now :)

@maelle
Copy link
Member

maelle commented Dec 5, 2022

combining would "easily" work with #588, I tried the code below on fledge itself.

fledgling <- read_fledgling()
regroup_news(
    unlist(
      fledgling$news[1:(nrow(fledgling$news) - 1),]$news,
      recursive = FALSE
  )
)

@maelle
Copy link
Member

maelle commented Jan 2, 2023

Special care will be needed for "Internal changes only" (to be removed if there are other items!)

@maelle
Copy link
Member

maelle commented Jan 10, 2023

I think this combining should happen in bump_version() or something else lower level than pre_release() so that people who use a workflow like #147 can benefit. 🤔

@maelle
Copy link
Member

maelle commented Jan 30, 2023

should this go in milestone 1.0.1, as a low-hanging fruit ?

@krlmlr
Copy link
Contributor Author

krlmlr commented Feb 1, 2023

Is it low-hanging now?

I haven't reviewed the milestones in a while.

@maelle
Copy link
Member

maelle commented Feb 2, 2023

it will be once #588 is merged, at least I think so.

Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

3 participants