New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: edit pkgdown config to not lose search bar #225

Merged

christophsax merged 1 commit into main from maelle-patch-1

Jul 17, 2024

Member

maelle commented Jul 17, 2024

👋 @christophsax!

fixing the URL (the rOpenSci docs building system does not support dev mode at the moment)
I removed the navbar related config. Compared to the default https://pkgdown.r-lib.org/articles/customise.html#navbar-heading the config only meant calling the articles section "Advanced". With the current config, and the new pkgdown version we're about to use in the system, you'd lose the search bar.

If you prefer I can tweak the config so "Articles" keep getting shown under "Advanced".


          docs: edit pkgdown config to not lose search bar

2bebf12

maelle requested a review from christophsax

July 17, 2024 15:27

maelle mentioned this pull request

New pkgdown issues ropensci-org/rotemplate#112

Closed

christophsax approved these changes

View reviewed changes

Collaborator

christophsax left a comment

@maelle thanks a lot! Looks great.

christophsax merged commit 0a0a4a2 into main

6 checks passed

christophsax deleted the maelle-patch-1 branch

July 17, 2024 16:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet