Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing tidyverse dependency #77

Merged
merged 1 commit into from Sep 6, 2019
Merged

removing tidyverse dependency #77

merged 1 commit into from Sep 6, 2019

Conversation

boshek
Copy link
Collaborator

@boshek boshek commented Aug 31, 2019

Description

  • Removes tidyverse dependency and also catches a few other undeclared dependencies

Related Issue

Resolves #76

@codecov-io
Copy link

Codecov Report

Merging #77 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   78.73%   78.85%   +0.12%     
==========================================
  Files           5        5              
  Lines         583      577       -6     
==========================================
- Hits          459      455       -4     
+ Misses        124      122       -2
Impacted Files Coverage Δ
R/stations.R 32.55% <0%> (-0.52%) ⬇️
R/interpolate.R 88.29% <0%> (-0.25%) ⬇️
R/weather.R 97.59% <0%> (-0.01%) ⬇️
R/weathercan-pkg.R 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636c55c...3688f0d. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Aug 31, 2019

Codecov Report

Merging #77 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   78.73%   78.85%   +0.12%     
==========================================
  Files           5        5              
  Lines         583      577       -6     
==========================================
- Hits          459      455       -4     
+ Misses        124      122       -2
Impacted Files Coverage Δ
R/stations.R 32.55% <0%> (-0.52%) ⬇️
R/interpolate.R 88.29% <0%> (-0.25%) ⬇️
R/weather.R 97.59% <0%> (-0.01%) ⬇️
R/weathercan-pkg.R 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636c55c...3688f0d. Read the comment docs.

@boshek boshek marked this pull request as ready for review September 1, 2019 00:22
@steffilazerte steffilazerte merged commit 80a56e4 into master Sep 6, 2019
@steffilazerte steffilazerte deleted the fix_dep branch September 6, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undeclared tidyverse dependency
3 participants