Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TFT_eSPI_Button Fixes #73

Closed
wants to merge 2 commits into from
Closed

TFT_eSPI_Button Fixes #73

wants to merge 2 commits into from

Conversation

tobozo
Copy link

@tobozo tobozo commented Oct 30, 2020

Fix for the following issues:

  • TFT_eSPI_Button::contains() always returns true
  • TFT_eSPI_Button::justPressed() and TFT_eSPI_Button::justReleased() always return true
  • TFT_eSPI_Button::press() seems ineffective
  • M5Buttons::drawFunction() button text isn't properly centered when using MC_DATUM with margins (margins should be ignored for text positioning)

@tobozo tobozo changed the title TFT_eSPI Fixes TFT_eSPI_Button Fixes Oct 30, 2020
@tobozo tobozo mentioned this pull request Nov 10, 2020
Closed
@tobozo tobozo mentioned this pull request Dec 5, 2020
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tobozo