EncodeBase58: don't convert little- to big-endian just to undo it

roques · Nov 13, 2012 · 8ed9c48 · 8ed9c48
1 parent f2b1280
commit 8ed9c48
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/src/base58.h b/src/base58.h
@@ -32,14 +32,9 @@ inline std::string EncodeBase58(const unsigned char* pbegin, const unsigned char
     CBigNum bn58 = 58;
     CBigNum bn0 = 0;
 
-    // Convert big endian data to little endian
-    // Extra zero at the end make sure bignum will interpret as a positive number
-    std::vector<unsigned char> vchTmp(pend-pbegin+1, 0);
-    reverse_copy(pbegin, pend, vchTmp.begin());
-
-    // Convert little endian data to bignum
+    // Convert big endian data to bignum
     CBigNum bn;
-    bn.setvch(vchTmp);
+    BN_bin2bn(pbegin, pend - pbegin, &bn);
 
     // Convert bignum to std::string
     std::string str;