making sed work with both unix and mac os x #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.2.0
The Gruntfile runs stylelint, which errors with "font-family-no-missing-generic-family-keyword" undefined. This rule was added in styleline 8.3.0, and our package.json here is earlier than that. Updating it to force a version that works. Error running npm test: ``` Running "stylelint:simple" (stylelint) task Warning: Running stylelint failed Error: Undefined rule font-family-no-missing-generic-family-keyword at module.exports (/Users/ralberth/MagicMirror/modules/MMM-MinecraftStatus/node_modules/stylelint/lib/utils/configurationError.js:8:27) at Object.keys.forEach.ruleName (/Users/ralberth/MagicMirror/modules/MMM-MinecraftStatus/node_modules/stylelint/lib/augmentConfig.js:279:13) at Array.forEach (<anonymous>:null:null) at normalizeAllRuleSettings (/Users/ralberth/MagicMirror/modules/MMM-MinecraftStatus/node_modules/stylelint/lib/augmentConfig.js:275:29) at augmentConfigBasic.then.then.then.then.augmentedConfig (/Users/ralberth/MagicMirror/modules/MMM-MinecraftStatus/node_modules/stylelint/lib/augmentConfig.js:84:12) at <anonymous>:null:null Use --force to continue. ``` See stylelint/stylelint#3042 for description.
Update version of stylelint
|
Travis build is failing due to some |
|
Bumped some of the package versions and bumped node versions for travis runs. Tests are passing now. |
|
Hey Sergey, Thanks you! This is a good work for issue with sed. PS: Never a repo is too old if work for someones ;) |
|
I've change the PR against the |
This was referenced Nov 27, 2019
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for
seddifferences between GNU and OS X versions.Hey Rodrigo, I know this repo is somewhat old. I grabbed it to make another MMM module and found that issue from a while ago. Here is my proposed solution based on https://stackoverflow.com/a/51060063
fixes #3