Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused var #220

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Removed unused var #220

merged 2 commits into from
Aug 15, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Aug 14, 2023

Related with this comment #177 (comment)

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Aug 14, 2023
@ahcorde ahcorde mentioned this pull request Aug 14, 2023
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the immediate fix :)

@ahcorde
Copy link
Collaborator Author

ahcorde commented Aug 14, 2023

@bmagyar or @destogl can you approved this too?

@bmagyar
Copy link
Member

bmagyar commented Aug 15, 2023

Less code, happier maintainers.

We can always revert it if we realize we need it again

@bmagyar bmagyar merged commit 174e6b8 into master Aug 15, 2023
5 checks passed
@bmagyar bmagyar deleted the ahcorde/rolling/unused_var branch August 15, 2023 05:21
@ahcorde
Copy link
Collaborator Author

ahcorde commented Aug 15, 2023

https://github.com/Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 15, 2023
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 174e6b8)
ahcorde added a commit that referenced this pull request Aug 15, 2023
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 174e6b8)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants