Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the C++ version to 17 #221

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Set the C++ version to 17 #221

merged 4 commits into from
Aug 15, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Aug 14, 2023

We should backport this to humble and iron

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Aug 14, 2023
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as it is standard since galactic acc to REP-2000

@ahcorde ahcorde enabled auto-merge (squash) August 14, 2023 10:58
@bmagyar
Copy link
Member

bmagyar commented Aug 14, 2023

Just got a buildfarm fail email. Related to this?

@ahcorde
Copy link
Collaborator Author

ahcorde commented Aug 14, 2023

buildfarm should email you only with merged PRs, isn't it?

@ahcorde ahcorde disabled auto-merge August 15, 2023 17:25
@ahcorde ahcorde merged commit 6da415c into master Aug 15, 2023
5 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/cpp17 branch August 15, 2023 17:26
@ahcorde
Copy link
Collaborator Author

ahcorde commented Aug 15, 2023

https://github.com/Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 15, 2023
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 6da415c)
ahcorde added a commit that referenced this pull request Aug 15, 2023
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 6da415c)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants