Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ahcorde/update/ros2 control #38

Conversation

guru-florida
Copy link
Contributor

In a nutshell:

  • fix errors due to names of members in the TransmissionInfo, ActuatorInfo, etc., interfaces were renamed in ros2_controls recent PR to be consistent with ros2_controls naming convention.
  • moved declaration of PID parameters to precede the call to the PidROS constructor. PidROS looks for these parameters during construction and was causing SEGVs sometimes. In my debugger it seemed like the construction of the contained ParameterService was causing "parameter changed" events to fire and this was the source of the SEGVs. Also, the declaration of parameters didnt have defaults so log was complaining about parameters not being of floating type.
  • To fix the issue of invalid handles, I split the joint loop in initSim into two. First registering handles, only then are handles retrieved and limits and PID can continue initializing.
  • removed the GazeboRosControlPrivate parseTransmissionsFromURDF method. It was a 1 line call to the transmission parser and regardless of parsing it returned true so didnt handle errors. plugin Load now calls parser directly and catches errors.

…iner and returns true always, thus not handling errors. plugin now calls transmission parser directly and catches error exception
…he PID constructor's ParameterInterface will cause parameter events to fire (and occasionally cause a SEGV). Also added defaults to force floating type on parameter to fix log errors due to wrong parameter type
…handles are fetched, then a second loop continues joint limit and PID setup
@ahcorde ahcorde merged commit 77a2b17 into ros-controls:ahcorde/update/ros2_control Oct 27, 2020
@ahcorde
Copy link
Collaborator

ahcorde commented Oct 27, 2020

Thank you @guru-florida !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants