-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated with ros2-control Foxy API #44
Merged
Merged
Changes from 2 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
c94af39
Updated with ros2-control foxy API
ahcorde b61b137
Fixed dependency
ahcorde a0ef367
make compile on osx (#46)
Karsten1987 a69ff7c
Fixed velocity example
ahcorde 868b07a
Merge branch 'ahcorde/update/foxy' of https://github.com/ros-simulati…
ahcorde 02ac826
make linters happy
ahcorde 90a0b6f
updated Dockerfile
ahcorde 2933f8d
Added effort example
ahcorde 7334f06
Instructions to run with moveit2
ahcorde f5b1acc
updated readme
ahcorde a9b771a
Added PIMPL pattern and other fixes
ahcorde 973e961
updated Dockerfile
ahcorde fe3a901
changed log level
ahcorde 436c9f9
Fixed gazebo_period units
ahcorde 45aa6c9
Updated CI
ahcorde 0479a9d
updated CI
ahcorde 6047ae9
updated CI
ahcorde 30a6124
update CI
ahcorde 240de77
updated Dockerfile
ahcorde f465d60
Added feedback
ahcorde 60e0022
make linters happy
ahcorde 07417e9
Removed PID controllers
ahcorde 31399db
make linters happy
ahcorde 9e5d685
Removed transmission interface
ahcorde 970adeb
Removed e-stop
ahcorde 9af1bfa
make linters happy
ahcorde 2822a9a
clean code
ahcorde 27ecc75
Fix CI
ahcorde f8b0871
Changed log level of a trace
ahcorde 595ba17
Added rclcpp dependency to gazebo_hardware_plugin
ahcorde da262d9
Fixed bug in control method
ahcorde 794da79
Support more than one ros2_control tag
ahcorde f84047f
make linters happy
ahcorde 4889311
unify yaml files
ahcorde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<library path="gazebo_hardware_plugins"> | ||
<class | ||
name="gazebo_ros2_control/GazeboSystem" | ||
type="gazebo_ros2_control::GazeboSystem" | ||
base_class_type="gazebo_ros2_control::GazeboSystemInterface"> | ||
<description> | ||
GazeboPositionJoint | ||
</description> | ||
</class> | ||
</library> |
168 changes: 0 additions & 168 deletions
168
gazebo_ros2_control/include/gazebo_ros2_control/default_robot_hw_sim.hpp
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a gazebo requirement? Is this a ros2_control requirement? We were planning to introduce some sort of e-stop handling but nothing is really designed for it yet. Is this to fulfill that use-case or a different one? I'd like to avoid having to remove functionality from the plugin/declare obsolete when we didn't really need to add it yet.