Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to check position controller #134

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Add test to check position controller #134

merged 3 commits into from
Jun 7, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented May 16, 2023

This test allows to check the position controller behaviour and avoid regressions.

If this one is fine I will create the other controllers

@ahcorde
Add test to check position controller
28e7f48 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested review from destogl and bmagyar May 16, 2023 15:26
@ahcorde ahcorde self-assigned this May 16, 2023
@ahcorde
make linters happy
90f6806 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
christophfroehlich
christophfroehlich approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bmagyar
bmagyar approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, much needed!! thank you

@bmagyar bmagyar merged commit 70fb797 into master Jun 7, 2023
6 checks passed
@bmagyar bmagyar deleted the ahcorde/end_to_end_test branch June 7, 2023 11:14
@ahcorde
Copy link
Collaborator Author

ahcorde commented Jun 7, 2023

https://github.com/Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2023 •
edited

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 7, 2023
@ahcorde @mergify
Add test to check position controller (#134)
21cf8ee 
* Add test to check position controller

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

* make linters happy

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 70fb797)
@mergify mergify bot mentioned this pull request Jun 7, 2023
Merged
ahcorde added a commit that referenced this pull request Jun 8, 2023
@mergify @ahcorde
Add test to check position controller (backport #134) (#147)
ee2cb2c 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@bmagyar bmagyar bmagyar approved these changes

@destogl destogl Awaiting requested review from destogl

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahcorde @christophfroehlich @bmagyar