Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undeclared position_proportional_gain_ #247

Closed
roncapat opened this issue Mar 14, 2024 · 1 comment
Closed

Undeclared position_proportional_gain_ #247

roncapat opened this issue Mar 14, 2024 · 1 comment

Comments

@roncapat
Copy link
Contributor

In #114, position_proportional_gain_ has been added.

In my opinion, it would be nice to declare it through the node handler. I believe that, unless allow_undeclared_parameters is set to true, there is no possibility to change the default gain (0.05). Am I right? Or what is the current official way, if any, to tune that value?
Fixit-Davide added a commit to Fixit-Davide/gz_ros2_control that referenced this issue Mar 14, 2024
@Fixit-Davide
Fix ros-controls#247
a563414
@roncapat
Copy link
Contributor Author

PR: #248

mergify bot pushed a commit that referenced this issue Mar 15, 2024
@Fixit-Davide @mergify
Fix #247 (#248)
5814b14 
(cherry picked from commit 94745e6)
mergify bot pushed a commit that referenced this issue Mar 15, 2024
@Fixit-Davide @mergify
Fix #247 (#248)
db449db 
(cherry picked from commit 94745e6)
ahcorde pushed a commit that referenced this issue Mar 15, 2024
@mergify @Fixit-Davide
Fix #247 (#248) (#250)
501be7f 
(cherry picked from commit 94745e6)

Co-authored-by: Graziato Davide <85335579+Fixit-Davide@users.noreply.github.com>
ahcorde pushed a commit that referenced this issue Mar 15, 2024
@mergify @Fixit-Davide
Fix #247 (#248) (#251)
32e5a87 
(cherry picked from commit 94745e6)

Co-authored-by: Graziato Davide <85335579+Fixit-Davide@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roncapat