Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #247 - explicitly declare position_proportional_gain parameter (backport #248) #250

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 15, 2024

With this patch, you can change position gain with this config file lines:

gz_ros_control:
  ros__parameters:
    position_proportional_gain: 0.5
```<hr>This is an automatic backport of pull request #248 done by [Mergify](https://mergify.com).

(cherry picked from commit 94745e6)
@ahcorde ahcorde merged commit 501be7f into humble Mar 15, 2024
5 checks passed
@ahcorde ahcorde deleted the mergify/bp/humble/pr-248 branch March 15, 2024 14:45
@destogl
Copy link
Member

destogl commented Mar 28, 2024

@ahcorde I am having issues with this fix on humble crashing with error:

parameter 'position_proportional_gain' has already been declared

After reverting this commit, the simulation starts as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants