Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for initial_values for hardware interfaces when starting simulation. #27

Merged

Conversation

destogl
Copy link
Member

@destogl destogl commented Jan 14, 2022

This PR adds support for initial values to set the hardware's initial states in the simulation.

This functionality is based on the following ros2_control PR:

Here is an example of its use in FakeHardware.

The ros2_control changes are released but not yet synced.

@destogl destogl requested a review from ahcorde as a code owner January 14, 2022 15:51
@osrf-triage osrf-triage added this to Inbox in Core development Jan 14, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Jan 14, 2022
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO ?

@ahcorde
Copy link
Collaborator

ahcorde commented Jan 18, 2022

Hi @destogl, I'm trying to compile this. Is initial_values feature only available in rolling ?

@destogl
Copy link
Member Author

destogl commented Jan 18, 2022

Hi @destogl, I'm trying to compile this. Is initial_values feature only available in rolling ?

Yes, this is rolling-only feature. I am not sure if it is synced already, but it is released.

@destogl destogl force-pushed the add-support-for-initial-position branch from 8d031f9 to 59db656 Compare January 18, 2022 16:45
@destogl
Copy link
Member Author

destogl commented Jan 18, 2022

DCO ?

Sorry about that!

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the same example as you included in this PR here ?

@destogl
Copy link
Member Author

destogl commented Jan 20, 2022

Can you add the same example as you included in this PR here ?

Do you want to have two additional files for it? In this PR I embedded the example of initial_value into the existing one because we actually change only one line compared to the usual examples. TBH I rather prefer approach I done here. Otherwise we just add "file-noise" without much value in them.

If you insist to add an additional example, I'll add it, but as I said, I think it is overkill.

@destogl
Copy link
Member Author

destogl commented Jan 27, 2022

@ahcorde I think we can go on with this in the same way as had to be done for gazebo_ros2_control.

@ahcorde
Copy link
Collaborator

ahcorde commented Jan 27, 2022

@destogl the PR is ready #30

Signed-off-by: Denis Štogl <denis@stogl.de>
Signed-off-by: Denis Štogl <denis@stogl.de>
Signed-off-by: Denis Štogl <denis@stogl.de>
@destogl destogl force-pushed the add-support-for-initial-position branch from 88a1f06 to be808c3 Compare January 27, 2022 22:58
@ahcorde ahcorde merged commit 9dcac11 into ros-controls:main Jan 28, 2022
Core development automation moved this from In review to Done Jan 28, 2022
@destogl destogl deleted the add-support-for-initial-position branch January 28, 2022 08:56
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants