Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup launch files and add example for .xml launch file. #266

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

destogl
Copy link
Member

@destogl destogl commented Apr 2, 2024

When testing #265 I saw that launch files needs some cleaning and also that .xml launch file is missing, althrough much simpler in many cases.

@destogl destogl requested a review from ahcorde as a code owner April 2, 2024 09:28
@destogl destogl added the enhancement New feature or request label Apr 2, 2024
@destogl destogl self-assigned this Apr 2, 2024
@ahcorde ahcorde merged commit 9853c08 into master Apr 2, 2024
3 of 8 checks passed
@ahcorde ahcorde deleted the fix-launch-files branch April 2, 2024 11:13
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants