Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logic for hardware interfaces #68

Merged
merged 1 commit into from Jun 24, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jun 20, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

Related with this issue

#62

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested review from destogl and bmagyar June 20, 2022 12:12
@ahcorde ahcorde self-assigned this Jun 20, 2022
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good for now. Maybe at some point we have to add also hardware lifecycle in the simulation.

@destogl destogl merged commit 2046e47 into main Jun 24, 2022
@destogl destogl deleted the ahcorde/master/logic_hardware_interfaces branch June 24, 2022 15:10
@rcywongaa
Copy link
Contributor

Should this be backported to the humble branch?

@destogl
Copy link
Member

destogl commented Sep 10, 2022

Oh we should backport a lot to humble. Actually we should proabably reset it to master for now. It should work.

@c-rizz
Copy link
Contributor

c-rizz commented Dec 20, 2022

What is stopping from bringing this to humble? Currently the demos are broken on humble. The master branch seems to work fine (just had to fix ros_ign_gazebo to gz_sim).

livanov93 pushed a commit to livanov93/ign_ros2_control that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants