Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Make error message after trying to active controller more informative. #1066

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

destogl
Copy link
Member

@destogl destogl commented Jun 29, 2023

No description provided.

@destogl destogl self-assigned this Jun 29, 2023
@destogl destogl added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Jun 29, 2023
@github-actions github-actions bot requested a review from rosterloh June 29, 2023 13:13
@codecov-commenter
Copy link

Codecov Report

Merging #1066 (f74ead1) into master (925f5f3) will decrease coverage by 2.26%.
The diff coverage is 35.06%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
- Coverage   34.61%   32.36%   -2.26%     
==========================================
  Files          52       94      +42     
  Lines        2981     9837    +6856     
  Branches     1855     6628    +4773     
==========================================
+ Hits         1032     3184    +2152     
- Misses        310      778     +468     
- Partials     1639     5875    +4236     
Flag Coverage Δ
unittests 32.36% <35.06%> (-2.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 37.83% <ø> (-1.88%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 47.68% <ø> (-5.94%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.42% <ø> (ø)
... and 71 more

... and 19 files with indirect coverage changes

@bmagyar
Copy link
Member

bmagyar commented Jun 29, 2023

Before/after?;)

@bmagyar bmagyar merged commit ca33bcc into master Jul 5, 2023
15 of 17 checks passed
mergify bot pushed a commit that referenced this pull request Jul 5, 2023
@bmagyar bmagyar deleted the cm-message-after-activation branch December 4, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants