Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added controller manager runner to have update cycles #1075

Merged

Conversation

saikishor
Copy link
Member

This change fixes the flaky spawner and unspawner tests

@codecov-commenter
Copy link

Codecov Report

Merging #1075 (d54af8c) into master (925f5f3) will decrease coverage by 2.31%.
The diff coverage is 34.81%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
- Coverage   34.61%   32.31%   -2.31%     
==========================================
  Files          52       94      +42     
  Lines        2981     9909    +6928     
  Branches     1855     6682    +4827     
==========================================
+ Hits         1032     3202    +2170     
- Misses        310      784     +474     
- Partials     1639     5923    +4284     
Flag Coverage Δ
unittests 32.31% <34.81%> (-2.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 37.94% <ø> (-1.77%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 47.68% <ø> (-5.94%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.42% <ø> (ø)
... and 70 more

... and 20 files with indirect coverage changes

@saikishor saikishor force-pushed the fix_flaky_spawner_unspawner_tests branch from d54af8c to 80c576c Compare July 6, 2023 22:04
@saikishor saikishor marked this pull request as ready for review July 7, 2023 05:08
@bmagyar bmagyar added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Jul 7, 2023
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow :D thank you!

@bmagyar bmagyar merged commit 09c6da4 into ros-controls:master Jul 7, 2023
18 checks passed
mergify bot pushed a commit that referenced this pull request Jul 7, 2023
bmagyar pushed a commit that referenced this pull request Jul 7, 2023
(cherry picked from commit 09c6da4)

Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants