Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spawner to accept controllers list and start them in sequence #1139

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Update spawner to accept controllers list and start them in sequence #1139

merged 5 commits into from
Oct 30, 2023

Conversation

saikishor
Copy link
Member

This PR adds an ability to process a controller list by the spawner

@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited

Codecov Report

Merging #1139 (91d5f21) into master (bd6911d) will decrease coverage by 0.10%.
The diff coverage is 11.76%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
- Coverage   31.62%   31.53%   -0.10%     
==========================================
  Files          94       94              
  Lines       10838    10889      +51     
  Branches     7419     7465      +46     
==========================================
+ Hits         3428     3434       +6     
- Misses        804      805       +1     
- Partials     6606     6650      +44
Flag Coverage Δ
unittests 31.53% <11.76%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/test/test_spawner_unspawner.cpp 22.53% <11.76%> (-6.04%) ⬇️

@saikishor saikishor force-pushed the expand_spawner_to_accept_controller_list branch from 2cef54d to b853568 Compare October 19, 2023 03:34
@saikishor saikishor marked this pull request as ready for review October 21, 2023 21:22
christophfroehlich
christophfroehlich approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmagyar bmagyar added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Oct 30, 2023
@bmagyar bmagyar merged commit 4e78813 into ros-controls:master Oct 30, 2023
18 checks passed
mergify bot pushed a commit that referenced this pull request Oct 30, 2023
@saikishor @mergify
Update spawner to accept controllers list and start them in sequence (#…
2125380 
…1139)

(cherry picked from commit 4e78813)

# Conflicts:
#	controller_manager/controller_manager/spawner.py
#	controller_manager/controller_manager/unspawner.py
@mergify mergify bot mentioned this pull request Oct 30, 2023
Merged
bmagyar pushed a commit that referenced this pull request Nov 4, 2023
@mergify
Update spawner to accept controllers list and start them in sequence …
553d0a5 
…(backport #1139) (#1149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@bmagyar bmagyar bmagyar approved these changes

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@destogl destogl Awaiting requested review from destogl

@jaron-l jaron-l Awaiting requested review from jaron-l

@livanov93 livanov93 Awaiting requested review from livanov93

@qiayuanl qiayuanl Awaiting requested review from qiayuanl

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saikishor @christophfroehlich @bmagyar