Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify return_type nomenclature in hardware_interface and controller_interface #151

Closed
v-lopez opened this issue Sep 17, 2020 · 5 comments · Fixed by #374
Closed

Unify return_type nomenclature in hardware_interface and controller_interface #151

v-lopez opened this issue Sep 17, 2020 · 5 comments · Fixed by #374

Comments

@v-lopez
Copy link
Contributor

v-lopez commented Sep 17, 2020

I propose the name change to keep the same nomenclature as for hardware_interfaces. What do you think?

  return controller_interface::return_type::OK;

Originally posted by @destogl in #139 (comment)

hardware_interface uses OK and controller_interface uses SUCCESS

@bmagyar
Copy link
Member

bmagyar commented Sep 17, 2020

I agree and I think we should pick the shorter one, I vote for OK.

@destogl
Copy link
Member

destogl commented Sep 17, 2020

I vote also foe OK. It is a bit broader term, but still with a clear meaning.

@Karsten1987
Copy link
Contributor

OK sounds good to me, too.

@v-lopez
Copy link
Contributor Author

v-lopez commented Sep 18, 2020

All right, I'll do after #139 is merged to avoid conflicts

@destogl
Copy link
Member

destogl commented Feb 26, 2021

So we go with OK. Rename return_type::SUCCESS everywhere to return_type:OK. But keep SUCCESS where it is defined and make its value equal to OK. Mark SUCCESS is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants