Add find_package for ament_cmake_gen_version_h

[christophfroehlich]

We have the joint_limits package failing on the build farm since #1449

08:25:10 CMake Error at cmake_install.cmake:145 (file):
08:25:10   file INSTALL cannot find
08:25:10   "/tmp/binarydeb/ros-rolling-joint-limits-4.10.0/.obj-x86_64-linux-gnu/ament_generate_version_header/joint_limits/joint_limits/version.h":
08:25:10   No such file or directory.

@saikishor and myself tried to find the root cause, and why joint_limits is the only package failing.

We now think this might be due to a missing find_package(ament_cmake_gen_version_h REQUIRED). The other packages include rclcpp, which includes tracetools, which has this find_package and might export this dependency "upstream". This is missing in joint_limits.

Related to ament/ament_cmake#525

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (edfb971) to head (132acab).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1534      +/-   ##
==========================================
+ Coverage   87.65%   87.66%   +0.01%     
==========================================
  Files         102      102              
  Lines        8618     8617       -1     
  Branches      774      774              
==========================================
  Hits         7554     7554              
+ Misses        788      787       -1     
  Partials      276      276              

Flag	Coverage Δ
unittests	87.66% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

[saikishor]

Thanks for adding!

[clalancette]

See ament/ament_cmake#525 (comment) ; this is actually a bug in ament_generate_version_header. My best suggestion for right now is to remove it from this INTERFACE only package until we get that PR merged and released.