Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lifecycle node #261

Merged
merged 5 commits into from
Dec 12, 2020
Merged

Remove lifecycle node #261

merged 5 commits into from
Dec 12, 2020

Conversation

v-lopez
Copy link
Contributor

@v-lopez v-lopez commented Dec 9, 2020 •
edited
Loading

Summary of changes:

  • Change ControllerInterface::get_lifecycle_node to get_node
  • Add activate, configure and similar methods to ControllerInterface to emulate the API that LifecycleNode provided
  • The controllers are a bit more affected, check: Remove lifecycle node controllers ros2_controllers#124

destogl
destogl requested changes Dec 10, 2020
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not change ControllerInterface so massively, but add an additional layer...

controller_interface/include/controller_interface/controller_interface.hpp Outdated Show resolved Hide resolved
controller_interface/include/controller_interface/controller_interface.hpp Outdated Show resolved Hide resolved
controller_interface/include/controller_interface/controller_interface.hpp Show resolved Hide resolved
controller_interface/src/controller_interface.cpp Show resolved Hide resolved
controller_interface/src/controller_interface.cpp Show resolved Hide resolved
controller_interface/src/controller_interface.cpp Show resolved Hide resolved
v-lopez and others added 2 commits December 11, 2020 09:14
@v-lopez @destogl
Apply suggestions from code review
6da174a 
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
Add missing state include
aaabb42
@v-lopez v-lopez mentioned this pull request Dec 11, 2020
Merged
@bmagyar bmagyar mentioned this pull request Dec 12, 2020
Closed
@bmagyar
Copy link
Member

bmagyar commented Dec 12, 2020

Thanks guys! I'll be merging this now and review the controller side.

@bmagyar bmagyar merged commit 792c24d into ros-controls:master Dec 12, 2020
@vatanaksoytezer vatanaksoytezer mentioned this pull request Sep 21, 2021
Merged
@destogl destogl linked an issue Feb 24, 2022 that may be closed by this pull request
[Galactic+] Use LifecycleNode once transitions cannot be triggered by externals. #266
Closed
destogl added a commit to StoglRobotics-forks/ros2_control that referenced this pull request Aug 11, 2022
@destogl
Fix python version in the format workflow (ros-controls#261)
37015b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl requested changes

@bmagyar bmagyar bmagyar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Galactic+] Use LifecycleNode once transitions cannot be triggered by externals.
3 participants
@v-lopez @bmagyar @destogl