Remodel ros2controlcli #349
Conversation
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
fixes #320 Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
|
I will still have to modify the spawner and unspawner scripts to use the python api within the controller manager to get rid of the python subprocess calls. |
bmagyar
force-pushed
the
remodel_ros2controlcli
branch
from
671bb6d
to
f3fd943
Compare
|
merged #310, rebased this one |
There was a problem hiding this comment.
Good start but I think this PR needs the removal of those subprocess calls too to be complete.
Thanks for adding the gh actions, good catch!
Please always elaborate on OSX issues you find as you are the only source of this info in our group. It'd be nice if you could actually open an issue with them whenever you find some and mark PRs that resolve them, that way we know they are solved for everyone.
ros2controlcli/ros2controlcli/verb/load_configure_controller.py
Outdated
Show resolved
Hide resolved
Karsten1987
force-pushed
the
remodel_ros2controlcli
branch
from
f3fd943
to
5f381cb
Compare
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
|
So I ended up changing the spawner scripts as well and with these changes the tests seem to work again. I do believe there's a fine difference in the pep257 between the ros-tooling and ros-industrial CI. The source build (ros-tooling) seems to use a version which expects a semicolon |
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
| @@ -31,8 +30,8 @@ def add_arguments(self, parser, cli_name): | |||
| add_controller_mgr_parsers(parser) | |||
|
|
|||
| def main(self, *, args): | |||
| print("deprecated warning: Please use either 'load --state' or 'set_state'") | |||
There was a problem hiding this comment.
set_state should be set_controller_state
|
@Karsten1987 great job! Thanks for doing this! (I just opened a few follow-ups to clean the code even more) |
| @@ -31,8 +30,8 @@ def add_arguments(self, parser, cli_name): | |||
| add_controller_mgr_parsers(parser) | |||
|
|
|||
| def main(self, *, args): | |||
| print("deprecated warning: Please use either 'load --state' or 'set_state'") | |||
This currently sits on top of #310 but also addresses #341.
The current PR of @v-lopez does unfortunately not pass all its tests on OSX and I've noticed that the CLI package was in a rather wild state. This PR is also addressing their linters and refactors a lot of the node handling.
It also activates the tests of this package in the GH actions.