fix osx #428
Merged
fix osx #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destogl
approved these changes
Jun 2, 2021
v-lopez
pushed a commit
to pal-robotics-forks/ros2_control
that referenced
this pull request
Jun 4, 2021
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
livanov93
pushed a commit
to livanov93/ros2_control
that referenced
this pull request
Mar 22, 2023
* Change type cast wall timer period from second to nanoseconds.
create_wall_timer() expects delay in nanoseconds (duration object) however the type cast to seconds will result in 0 (if duration is less than 1s) and thus causing timer to be fired non stop resulting in very high CPU usage.
* Reset smartpointer so that create_wall_timer() call can destroy previous trajectory timer.
node->create_wall_timer() first removes timers associated with expired smartpointers before servicing current request. The JTC timer pointer gets overwrite only after the create_wall_timer() returns and thus not able to remove previous trajectory timer resulting in upto two timers running for JTC during trajectory execution. Althougth the previous timer does nothing but still get fired.
Signed-off-by: Arshad Mehmood <arshadm78@yahoo.com>
Signed-off-by: Arshad Mehmood <arshadm78@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osx reported a bunch of error, mainly about not finding
isnan. Then there were warnings about non-virtual destructors and unused variables.