Add an argument to define controller manager timeout #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karsten1987
approved these changes
Jun 21, 2021
|
@Karsten1987 I fixed the linter error, it is passing all controller_manager tests locally. BTW, is there a way to avoid |
|
There's currently no opt-out option but apparently they protect us from you mining bitcoin on our CI :D |
|
That kinda confused me, too. I actually don't know where this comes from. @bmagyar do you know what's going on there? |
bmagyar
approved these changes
Jun 21, 2021
|
Well apparently someone were mining some sweet crypto in hijacked GH actions. Ingenious! Also, I'll be merging this so let's welcome @lukicdarkoo to the Circle of Trust TM, may your CI jobs be ever-green ;) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running some "heavy" simulations and it takes more than 10s for our
ros2_controlplugin to load