Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct wrong call in shutdown method of ControllerInterface #460

Merged

Conversation

destogl
Copy link
Member

@destogl destogl commented Jul 12, 2021

No description provided.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm perplexed. Thanks!

Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend to change the title before merging to indicate what was changed.

@destogl destogl changed the title Correct obviously wrong call in controller interface. Correct wrong call in shutdown method of ControllerInterface Jul 13, 2021
@destogl destogl merged commit 8018f45 into ros-controls:master Jul 13, 2021
@destogl destogl deleted the correct-controller-interface-typo branch July 13, 2021 08:22
@destogl
Copy link
Member Author

destogl commented Jul 13, 2021

@Karsten1987 I renamed PR and then merged, but the proposed message kept the old name.... and I was too fast on my mouse... Sorry for not-so-nice commit message... :(

pac48 pushed a commit to pac48/ros2_control that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants