Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller manager doesn't return the controller's joints when it's inactive #464

Closed
JafarAbdi opened this issue Jul 15, 2021 · 2 comments · Fixed by #544
Closed

controller manager doesn't return the controller's joints when it's inactive #464

JafarAbdi opened this issue Jul 15, 2021 · 2 comments · Fixed by #544

Comments

@JafarAbdi
Copy link
Contributor

I'm trying to port moveit_ros_control_interface to ROS2 and it has an option to let moveit's trajectory execution manager automatically switch controllers depend on the joints in the received trajectory, but the problem we're having is ros2 controller manager doesn't return the joints name for the inactive controller,

I'm trying to fix it and looking at the code it seems like it's due to this line, should I open a PR that fixes it upstream .?

@destogl
Copy link
Member

destogl commented Jul 20, 2021

I think it is not simply that line. Actually, at current state, the CM has no idea about joints and interfaces of inactive controllers. This all happens when a controller tries to be activated. Having this option would need some more work to internally store the interfaces a controller need. I would be also feasible to get those values when the service is called, but this could prolong response time on the service...

@schornakj
Copy link
Contributor

I'm also interested in allowing the moveit_ros_control_interface to get info about which interfaces are associated with currently-inactive controllers. @destogl how fundamental of a change to the implementation of the controller manager would this be? Has there been more detailed discussion since @JafarAbdi's initial post about where modifications would need to be made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants