Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate controller manager test cases #476

Merged

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Jul 28, 2021

Trying to unentangle these larger collection of test cases depending on each other.

@bmagyar bmagyar force-pushed the separate_controller_manager_test_cases branch from 35d9e9f to fbbe55a Compare July 28, 2021 12:18
@bmagyar bmagyar force-pushed the separate_controller_manager_test_cases branch from 4ba8311 to 69da6d3 Compare August 9, 2021 20:47
@bmagyar bmagyar force-pushed the separate_controller_manager_test_cases branch from 69da6d3 to 866ca58 Compare August 9, 2021 21:30
@bmagyar
Copy link
Member Author

bmagyar commented Aug 9, 2021

@destogl this is really ready now

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to optimize this further.

@bmagyar bmagyar mentioned this pull request Aug 13, 2021
9 tasks
@bmagyar
Copy link
Member Author

bmagyar commented Aug 13, 2021

@destogl created a good first issue capturing your points here: #493

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, comments will be addressed in follow-ups.

@bmagyar bmagyar merged commit 9362f3e into ros-controls:master Aug 20, 2021
pac48 pushed a commit to pac48/ros2_control that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants