-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate controller manager test cases #476
Merged
bmagyar
merged 9 commits into
ros-controls:master
from
bmagyar:separate_controller_manager_test_cases
Aug 20, 2021
Merged
Separate controller manager test cases #476
bmagyar
merged 9 commits into
ros-controls:master
from
bmagyar:separate_controller_manager_test_cases
Aug 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmagyar
force-pushed
the
separate_controller_manager_test_cases
branch
from
July 28, 2021 12:18
35d9e9f
to
fbbe55a
Compare
bmagyar
force-pushed
the
separate_controller_manager_test_cases
branch
from
August 9, 2021 20:47
4ba8311
to
69da6d3
Compare
bmagyar
force-pushed
the
separate_controller_manager_test_cases
branch
from
August 9, 2021 21:30
69da6d3
to
866ca58
Compare
@destogl this is really ready now |
destogl
reviewed
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments to optimize this further.
9 tasks
destogl
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, comments will be addressed in follow-ups.
pac48
pushed a commit
to pac48/ros2_control
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to unentangle these larger collection of test cases depending on each other.