Automatic parameter declaration - enable existence of undeclared parameters from overrides #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-lopez
approved these changes
Aug 27, 2021
destogl
reviewed
Sep 9, 2021
| controller_name, rclcpp::NodeOptions().allow_undeclared_parameters(true)); | ||
| controller_name, rclcpp::NodeOptions() | ||
| .allow_undeclared_parameters(true) | ||
| .automatically_declare_parameters_from_overrides(true)); |
There was a problem hiding this comment.
I have a follow-up issue with this parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR comes in combination with #ros2_controllers/PR224.
PR enables undeclared parameters to be automatically declared if uploaded via overrides (e.g. yaml files). Helper function is also added to make declaration + check if some parameter already exists easier for components that inherit from ContorllerInterface.