Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct ros-controls/realtime_tools branch #619

Merged
merged 1 commit into from Jan 17, 2022

Conversation

wmmc88
Copy link
Contributor

@wmmc88 wmmc88 commented Jan 17, 2022

This change should also be backported to foxy and galactic. Found this from getting build errors locally due to missing new reset function for rt buffers.

Rolling, Foxy and Galactic all get binary releases from the foxy-devel branch, not the ros2_devel branch:
https://index.ros.org/p/realtime_tools/github-ros-controls-realtime_tools/#rolling
https://index.ros.org/p/realtime_tools/github-ros-controls-realtime_tools/#galactic
https://index.ros.org/p/realtime_tools/github-ros-controls-realtime_tools/#foxy

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good find

@bmagyar
Copy link
Member

bmagyar commented Jan 17, 2022

@Mergifyio backport to foxy

@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2022

backport to foxy

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@bmagyar
Copy link
Member

bmagyar commented Jan 17, 2022

@Mergifyio backport to galactic

@bmagyar bmagyar merged commit ff59110 into ros-controls:master Jan 17, 2022
mergify bot pushed a commit that referenced this pull request Jan 17, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2022

backport to foxy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 17, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2022

backport to galactic

✅ Backports have been created

bmagyar pushed a commit that referenced this pull request Jan 17, 2022
(cherry picked from commit ff59110)

Co-authored-by: Melvin Wang <melvin.mc.wang@gmail.com>
bmagyar pushed a commit that referenced this pull request Jan 17, 2022
(cherry picked from commit ff59110)

Co-authored-by: Melvin Wang <melvin.mc.wang@gmail.com>
@wmmc88 wmmc88 deleted the patch-1 branch January 17, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants