Replace RCUTILS_ with RCLCPP_ for logging #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JafarAbdi
force-pushed
the
pr-rclcpp_logger
branch
5 times, most recently
from
25c34b0
to
76d5366
Compare
Karsten1987
reviewed
Feb 21, 2020
There was a problem hiding this comment.
Thanks for PR. There are few nitpicks around alphabetical sort.
However, the github action fail with some uncrustify errors:
6: --- src/robot_hardware.cpp
6: +++ src/robot_hardware.cpp.uncrustify
6: @@ -83 +83,2 @@
6: - RCLCPP_ERROR(rclcpp::get_logger("joint state handle"),
6: + RCLCPP_ERROR(
6: + rclcpp::get_logger("joint state handle"),
6: @@ -97 +98,2 @@
6: - RCLCPP_ERROR(rclcpp::get_logger("joint state handle"),
6: + RCLCPP_ERROR(
6: + rclcpp::get_logger("joint state handle"),
6: @@ -111 +113,2 @@
6: - RCLCPP_ERROR(rclcpp::get_logger("joint cmd handle"),
6: + RCLCPP_ERROR(
6: + rclcpp::get_logger("joint cmd handle"),
6: @@ -125 +128,2 @@
Running ament_uncrustify locally gives no error, what could be the reason for this situation .? is there a config file used for uncrustify in the CI system .? I'll fix the other alpha sort comment today, Thanks! |
|
I suspect that you’re using eloquent but the current master branch is on par with the latest ros2 master and thus the uncrustify version used has changed.
That is annoying, but for this particular problem I believe you don’t have to build your ros2 version from scratch but solely rely on the linked github actions or travis.
… On Feb 24, 2020, at 6:16 AM, Jafar Abdi ***@***.***> wrote:
However, the github action fail with some uncrustify errors:
Running ament_uncrustify locally gives no error what could be the reason .?
I'll fix the other alpha sort comment today, Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
JafarAbdi
force-pushed
the
pr-rclcpp_logger
branch
4 times, most recently
from
aca19dd
to
27a4a0d
Compare
Karsten1987
reviewed
Feb 27, 2020
test_robot_hardware/include/test_robot_hardware/test_robot_hardware.hpp
Outdated
Show resolved
Hide resolved
|
@JafarAbdi Any updates on this? |
Closed
JafarAbdi
force-pushed
the
pr-rclcpp_logger
branch
from
27a4a0d
to
c336ad4
Compare
|
@Karsten1987 Sorry, I just saw your last review, I addressed the latest review and pushed the changes |
bmagyar
reviewed
Mar 5, 2020
Karsten1987
approved these changes
Mar 5, 2020
JafarAbdi
force-pushed
the
pr-rclcpp_logger
branch
from
c336ad4
to
d342488
Compare
destogl
pushed a commit
to StoglRobotics-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
…olated (ros-controls#62) * port over jtc interpolation formulas * update comments * account for 0 duration between points, fix tests accordingly * interpolate() and sample() functions now returns velocities and accelerations * now aborting due to outside_goal_tolerance * update comment * add pos, velocity and acceleration tests to test_trajectory * fix action tests, disable velocity goal tolerance due to uncommitted velocities * lint and uncrustify fixes * Fix rebase hiccup Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #59