Add CallbackReturn into controller_interface namespace for simpler usage in controllers. #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age in controllers.
github-actions
bot
requested review from
arne48,
bmagyar,
kasiceo,
mhubii,
TomoyaFujita2016 and
UsamaHamayun1
bmagyar
approved these changes
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
CallbackReturnintocontroller_interfacenamespace to enable clearer usage of constants in controllers.The idea comes from @fmauch from UR-Driver.
The concept is much more future-proof because if we ever change underlying management (state machine) users would not have to change their code.
It also avoids repetitive definition of
using...in each controller.@bmagyar if you agree with the concept, we have to open a follow-up issue to update all controllers.