đ”Add missing field in the test structures. #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
duringhof,
homalozoa,
kasiceo,
progtologist and
rosterloh
tylerjw
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Oof... vector<vector<vector>> đą
vector is a special case in the stl and is generally advised against because of the surprising [lack of] performance if you try to iterate over it. For some reason it was special cased and optimized for space in the stl instead of performance and actually bit packs like it was designed for some microcontroller.
bmagyar
approved these changes
Jun 30, 2022
pac48
pushed a commit
to pac48/ros2_control
that referenced
this pull request
Jan 26, 2024
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> (cherry picked from commit af54985bc09121d4ca5d45fba68effc279cb2689) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test were working, obviously by pure luck because I missed a filed. Funny that we didn't get any âmemory corruptionâ error, but probably because of the complex structures I was using.
We have three state in the actuator, as can be seen from the "is_available" fields (always few lines above).