Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and fix CI setup #752

Merged
merged 15 commits into from
Jun 30, 2022
Merged

Update and fix CI setup #752

merged 15 commits into from
Jun 30, 2022

Conversation

destogl
Copy link
Member

@destogl destogl commented Jun 30, 2022

This PR cleans and updates CI setup to have better overview, putting some details behind.
Everything was tested on my fork and should work without any problems. We should also back port it to galactic and foxy branch. See here for the "report".

I am disabling RHEL build for humble since docker container is not yet available. I have asked @jaron-l if he would like to build one as he did that for other versions.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@bmagyar bmagyar merged commit dabe19e into master Jun 30, 2022
@destogl destogl deleted the ci-setup-fix branch June 30, 2022 20:54
@destogl
Copy link
Member Author

destogl commented Jul 17, 2022

@Mergifyio backport galactic

@destogl
Copy link
Member Author

destogl commented Jul 17, 2022

@Mergifyio backport foxy

mergify bot pushed a commit that referenced this pull request Jul 17, 2022
* Add names to ABI compatibility workflows.
* Don't use source build on the old distros.
* Disable rhel build on PRs since it will failanyway.
* We need common linters in packages that generate messages since those auto automatically used.
* remove disabling of tests.

(cherry picked from commit dabe19e)

# Conflicts:
#	.github/workflows/foxy-abi-compatibility.yml
#	.github/workflows/foxy-binary-build-main.yml
#	.github/workflows/foxy-semi-binary-build-main.yml
#	.github/workflows/galactic-abi-compatibility.yml
#	.github/workflows/galactic-binary-build-main.yml
#	.github/workflows/galactic-semi-binary-build-main.yml
#	.github/workflows/humble-abi-compatibility.yml
#	.github/workflows/humble-source-build.yml
#	.github/workflows/reusable-industrial-ci-with-cache.yml
#	.github/workflows/reusable-ros-tooling-source-build.yml
#	.github/workflows/rolling-abi-compatibility.yml
#	.github/workflows/rolling-binary-build-main.yml
#	.github/workflows/rolling-binary-build-testing.yml
#	.github/workflows/rolling-rhel-binary-build.yml
#	.github/workflows/rolling-semi-binary-build-main.yml
#	.github/workflows/rolling-semi-binary-build-testing.yml
#	.github/workflows/rolling-source-build.yml
#	.github/workflows/source.yml
#	README.md
#	controller_manager_msgs/package.xml
@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2022

backport galactic

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 17, 2022
* Add names to ABI compatibility workflows.
* Don't use source build on the old distros.
* Disable rhel build on PRs since it will failanyway.
* We need common linters in packages that generate messages since those auto automatically used.
* remove disabling of tests.

(cherry picked from commit dabe19e)

# Conflicts:
#	.github/workflows/foxy-abi-compatibility.yml
#	.github/workflows/foxy-binary-build-main.yml
#	.github/workflows/foxy-semi-binary-build-main.yml
#	.github/workflows/galactic-abi-compatibility.yml
#	.github/workflows/galactic-binary-build-main.yml
#	.github/workflows/galactic-semi-binary-build-main.yml
#	.github/workflows/humble-abi-compatibility.yml
#	.github/workflows/humble-source-build.yml
#	.github/workflows/lint.yml
#	.github/workflows/reusable-industrial-ci-with-cache.yml
#	.github/workflows/reusable-ros-tooling-source-build.yml
#	.github/workflows/rolling-abi-compatibility.yml
#	.github/workflows/rolling-binary-build-main.yml
#	.github/workflows/rolling-binary-build-testing.yml
#	.github/workflows/rolling-rhel-binary-build.yml
#	.github/workflows/rolling-semi-binary-build-main.yml
#	.github/workflows/rolling-semi-binary-build-testing.yml
#	.github/workflows/rolling-source-build.yml
#	.github/workflows/source.yml
#	README.md
#	controller_manager_msgs/package.xml
@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2022

backport foxy

✅ Backports have been created

pac48 pushed a commit to pac48/ros2_control that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants