-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename class type to plugin name #api-breaking #abi-breaking #780
Rename class type to plugin name #api-breaking #abi-breaking #780
Conversation
a8b7109
to
f308b89
Compare
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
==========================================
- Coverage 34.61% 32.90% -1.72%
==========================================
Files 52 90 +38
Lines 2981 8510 +5529
Branches 1855 5668 +3813
==========================================
+ Hits 1032 2800 +1768
- Misses 310 674 +364
- Partials 1639 5036 +3397
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fully agree, but let's deprecate it first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comments to remove additional two lines before merging
This was broken in ros-controls/ros2_control#780
This was broken in ros-controls/ros2_control#780
Changes to internal API, not really an issue but I think that the message changes justify API and ABI break flags
Closes #624