Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename class type to plugin name #api-breaking #abi-breaking #780

Merged

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Jul 18, 2022

Changes to internal API, not really an issue but I think that the message changes justify API and ABI break flags

Closes #624

@bmagyar bmagyar force-pushed the rename-class-type-to-plugin-name branch from a8b7109 to f308b89 Compare July 18, 2022 07:24
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2022

Codecov Report

Merging #780 (b1bbf8d) into master (925f5f3) will decrease coverage by 1.71%.
The diff coverage is 37.18%.

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
- Coverage   34.61%   32.90%   -1.72%     
==========================================
  Files          52       90      +38     
  Lines        2981     8510    +5529     
  Branches     1855     5668    +3813     
==========================================
+ Hits         1032     2800    +1768     
- Misses        310      674     +364     
- Partials     1639     5036    +3397     
Flag Coverage Δ
unittests 32.90% <37.18%> (-1.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/realtime.cpp 0.00% <0.00%> (ø)
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 50.09% <ø> (-3.53%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 8.62% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp 32.44% <ø> (+4.25%) ⬆️
... and 106 more

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully agree, but let's deprecate it first.

destogl
destogl previously approved these changes Nov 26, 2022
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comments to remove additional two lines before merging

hardware_interface/src/resource_manager.cpp Outdated Show resolved Hide resolved
@bmagyar bmagyar merged commit f58d407 into ros-controls:master Dec 6, 2022
christophfroehlich added a commit to christophfroehlich/gazebo_ros2_control that referenced this pull request Dec 28, 2022
ahcorde pushed a commit to ros-controls/gazebo_ros2_control that referenced this pull request Dec 29, 2022
destogl added a commit to ros-controls/gz_ros2_control that referenced this pull request Jan 5, 2023
ahcorde pushed a commit to ros-controls/gz_ros2_control that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename class_name to something more human-friendly
3 participants