Option to search for controller manager in the same namespace as spawner

[tonynajjar]

While it is possible to specify the controller manager's name including a namespace with the --controller-manager option, searching for the controller manager in the same namespace as the spawner makes my launch files for multi-robot simulation much simpler. That way I don't need to pass the namespace as a launch argument.

P.S: Happy to spend more time fixing CI and writing a test if the idea is approved

[bmagyar]

I really like the idea, in fact so much I'd prefer it to be the default behaviour!
What do you think @destogl?

[tonynajjar]

Nice! I do think it makes sense to be the default. One could still specify the controller name without a namespace if needed

Let me know if I should go forward with it

[destogl]

Let me know if I should go forward with it

Yes, this should be default behavior. Now sure if we need than this flag you introduced or something else (different name).

[tonynajjar]

Now sure if we need than this flag you introduced or something else (different name).

If that's the default behavior, then I don't think we need any flag. Will submit some changes in a bit

[tonynajjar]

Ready for review again.

The logic is that the spawner's namespace is added to the controller manager's name only if:

1. The namespace exists (is not "/")
2. the controller manager's name is not fully resolved (starts with "/")

I also changed the default for the controller manager's name to not be fully resolved

[bmagyar]

Thanks very much, let's roll it!

[destogl]

@Mergifyio backport humble

[mergify]

backport humble

✅ Backports have been created

• #839 Option to search for controller manager in the same namespace as spawner (backport #810) has been created for branch humble