-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't ask for export reference interface inthe callback of controller is not 'inactive' or 'active' #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
jackcenter,
jaron-l,
malapatiravi,
mcbed and
Serafadam
September 28, 2022 20:30
destogl
force-pushed
the
fix-ask-ref-itf-when-unconfigured
branch
from
September 29, 2022 06:57
6c56b23
to
4cd041a
Compare
… is not 'inactive' or 'active'
destogl
force-pushed
the
fix-ask-ref-itf-when-unconfigured
branch
from
September 29, 2022 08:15
4cd041a
to
581c434
Compare
Codecov Report
@@ Coverage Diff @@
## master #824 +/- ##
==========================================
- Coverage 34.61% 32.63% -1.99%
==========================================
Files 52 91 +39
Lines 2981 9264 +6283
Branches 1855 6225 +4370
==========================================
+ Hits 1032 3023 +1991
- Misses 310 720 +410
- Partials 1639 5521 +3882
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
Oct 1, 2022
@Mergifyio backport humble |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix as per title.
When testing #813 I get following output:
This fixes this and respects more the lifecycle.