Use explicit duration type for time_point to be compatible with macOS #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use std::chrono::nanoseconds as std::chrono::time_point template parameter to help compilation on macOS as its std::chrono::system_clock::time_point defaults to std::chrono::milliseconds for duration type
github-actions
bot
requested review from
aprotyas,
bmagyar,
destogl,
jackcenter,
jaron-l,
peterdavidfagan and
progtologist
bmagyar
approved these changes
Nov 4, 2022
|
This issue still remains in humble. It would be great, if this patch could be backported to humble as well. |
Feel free to make the pull request! This is a great idea and I'm sure everyone would appreciate your help. |
|
@Mergifyio backport humble |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
cwecht
pushed a commit
to cwecht/ros2_control
that referenced
this pull request
Nov 30, 2022
… use std::chrono::nanoseconds as std::chrono::time_point template parameter to help compilation on macOS as its std::chrono::system_clock::time_point defaults to std::chrono::milliseconds for duration type (ros-controls#848)
Closed
cwecht
pushed a commit
to cwecht/ros2_control
that referenced
this pull request
Nov 30, 2022
… use std::chrono::nanoseconds as std::chrono::time_point template parameter to help compilation on macOS as its std::chrono::system_clock::time_point defaults to std::chrono::milliseconds for duration type (ros-controls#848)
|
@Mergifyio backport humble |
✅ Backports have been created
|
destogl
pushed a commit
that referenced
this pull request
Nov 30, 2022
… use std::chrono::nanoseconds as std::chrono::time_point template parameter to help compilation on macOS as its std::chrono::system_clock::time_point defaults to std::chrono::milliseconds for duration type (#848) (#866) (cherry picked from commit ec2ba91) Co-authored-by: light-tech <lightech@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS,
std::chrono::system_clock::time_pointhasstd::chrono::millisecondsfor its duration so compilation fails.Changing the declaration to one with an explicit duration template parameter
std::chrono::time_point<std::chrono::system_clock, std::chrono::nanoseconds>helps remove the system dependent implementation ofstd::chrono::system_clock.