Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update rate setting from gazebo_ros2_control #874

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Fix update rate setting from gazebo_ros2_control #874

merged 1 commit into from
Jan 16, 2023

Conversation

tonynajjar
Copy link
Contributor

@tonynajjar tonynajjar commented Dec 6, 2022 •
edited

progtologist
progtologist approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@progtologist progtologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice catch!

@bmagyar bmagyar merged commit a4f682e into ros-controls:master Jan 16, 2023
@bmagyar
Copy link
Member

bmagyar commented Jan 16, 2023

@Mergifyio backport to humble

mergify bot pushed a commit that referenced this pull request Jan 16, 2023
@mergify
Merge branch 'fix-update-rate' into humble (#874)
50fe9af 
(cherry picked from commit a4f682e)

# Conflicts:
#	controller_manager/src/controller_manager.cpp
@mergify mergify bot mentioned this pull request Jan 16, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Jan 16, 2023

backport to humble

✅ Backports have been created

bmagyar pushed a commit that referenced this pull request Jan 19, 2023
@mergify @destogl
Fix update rate setting from gazebo_ros2_control (backport #874) (#904)
584b131 
* Merge branch 'fix-update-rate' into humble (#874)

(cherry picked from commit a4f682e)

# Conflicts:
#	controller_manager/src/controller_manager.cpp

* Diagnostic updated is not in humble

Co-authored-by: Tony Najjar <tony.najjar@logivations.com>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
@bmagyar bmagyar mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@progtologist progtologist progtologist approved these changes

@bmagyar bmagyar bmagyar approved these changes

@destogl destogl Awaiting requested review from destogl

@duringhof duringhof Awaiting requested review from duringhof

@jaron-l jaron-l Awaiting requested review from jaron-l

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@rosterloh rosterloh Awaiting requested review from rosterloh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tonynajjar @bmagyar @progtologist