Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent controller manager from crashing when controller's plugin has error during loading. #881

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Prevent controller manager from crashing when controller's plugin has error during loading. #881

merged 1 commit into from
Dec 20, 2022

Conversation

destogl
Copy link
Member

@destogl destogl commented Dec 20, 2022

The error usually happens is something is wrong in plugin.xml file or class is not exported correctly.

@destogl destogl self-assigned this Dec 20, 2022
bmagyar
bmagyar approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@bmagyar bmagyar merged commit 57d45c9 into master Dec 20, 2022
@bmagyar
Copy link
Member

bmagyar commented Dec 20, 2022

@Mergifyio backport to humble

mergify bot pushed a commit that referenced this pull request Dec 20, 2022
@destogl @mergify
Prevent controller manager from crashing when controller's plugin has…
5a3e67e 
… error during loading. (#881)

(cherry picked from commit 57d45c9)
@mergify mergify bot mentioned this pull request Dec 20, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Dec 20, 2022

backport to humble

✅ Backports have been created

bmagyar pushed a commit that referenced this pull request Dec 20, 2022
@mergify @destogl
Prevent controller manager from crashing when controller's plugin has…
d0bc97c 
… error during loading. (#881) (#882)

(cherry picked from commit 57d45c9)

Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
@destogl destogl deleted the fix-cm-crash-on-controller-loading branch February 9, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@duringhof duringhof Awaiting requested review from duringhof

@erickisos erickisos Awaiting requested review from erickisos

@homalozoa homalozoa Awaiting requested review from homalozoa

@mcbed mcbed Awaiting requested review from mcbed

@Serafadam Serafadam Awaiting requested review from Serafadam

Assignees

@destogl destogl

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@destogl @bmagyar