Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize output of controller spawner #909

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Optimize output of controller spawner #909

merged 1 commit into from
Jan 19, 2023

Conversation

destogl
Copy link
Member

@destogl destogl commented Jan 19, 2023

All output in spawner was set to "info" severity. This makes debugging quite hard.

  • "fatal" - if loading fails
  • "error" - on errors
  • "warnings" - on waringn
  • make controller name bold in output

@destogl destogl self-assigned this Jan 19, 2023
@destogl destogl requested a review from bmagyar January 19, 2023 19:48
@bmagyar bmagyar merged commit 98212d4 into master Jan 19, 2023
@destogl destogl deleted the spawner-optimize-output branch January 21, 2023 09:06
@destogl
Copy link
Member Author

destogl commented Jan 21, 2023

@Mergifyio backport humble

mergify bot pushed a commit that referenced this pull request Jan 21, 2023
@destogl @mergify
Optimize output of controller spawner (#909)
9c972bd 
(cherry picked from commit 98212d4)

# Conflicts:
#	controller_manager/controller_manager/spawner.py
@mergify mergify bot mentioned this pull request Jan 21, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Jan 21, 2023

backport humble

✅ Backports have been created

bmagyar pushed a commit that referenced this pull request Jan 25, 2023
@mergify @destogl
Optimize output of controller spawner (backport #909) (#911)
354fa76 
* Optimize output of controller spawner (#909)

(cherry picked from commit 98212d4)

# Conflicts:
#	controller_manager/controller_manager/spawner.py

* Resolve merge conflict.

Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
pac48 pushed a commit to pac48/ros2_control that referenced this pull request Jan 26, 2024
@dependabot
Bump ros-tooling/action-ros-ci from 0.2.6 to 0.3.5 (ros-controls#909)
dd35300 
Bumps [ros-tooling/action-ros-ci](https://github.com/ros-tooling/action-ros-ci) from 0.2.6 to 0.3.5.
- [Release notes](https://github.com/ros-tooling/action-ros-ci/releases)
- [Commits](ros-tooling/action-ros-ci@0.2.6...0.3.5)

---
updated-dependencies:
- dependency-name: ros-tooling/action-ros-ci
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@homalozoa homalozoa Awaiting requested review from homalozoa

@jaron-l jaron-l Awaiting requested review from jaron-l

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@rosterloh rosterloh Awaiting requested review from rosterloh

@Serafadam Serafadam Awaiting requested review from Serafadam

Assignees

@destogl destogl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@destogl @bmagyar