-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CM] Remove support for the description parameter and use only robot_description
topic
#1358
Conversation
May I raise the question (has probably been discussed elsewhere, but I couldn't find a note in #940): Why do we subscribe to If we instead subscribed to |
This is intended, but soley by myself :) The idea was to work with the local namespace. Reading your comment, you are right. for the cases where one has multiple controller managers, one should remap those instead making people to do remapping by default. |
so... should we change that? |
I'll adjust! |
So when using multiple controller managers, we remap the topic within the launch file like this?
Am I right? |
That's the idea. |
This pull request is in conflict. Could you fix it @destogl? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add migration notes to https://github.com/ros-controls/ros2_control/blob/master/doc/migration/Iron.rst
This pull request is in conflict. Could you fix it @destogl? |
Now conflicting |
…cription-from-param
I've resolved the conflicts on my fork: fmauch@7418dbb I could either make a PR to this PR's branch, or I could make a new PR replacing this or a maintainer could push my merge commit to this PR's branch. I think the latter is the best option, as then the history of this PR will be retained and git history will stay somehow understandable. The tests run fine and I tested the UR driver against this locally. |
…-param Merge current master into cm-remove-robot-description
robot_description
topic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fyi @fmauch I've added a commit and added this change to the migration guide.
Part of the #1237.
Has to be adjusted after #1354 is merged.