Remove deprecated mimic parameter from ros2_control tag #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bijoua29,
bmagyar,
DasRoteSkelett,
destogl,
jaron-l and
peterdavidfagan
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1553 +/- ##
==========================================
+ Coverage 87.80% 87.81% +0.01%
==========================================
Files 102 102
Lines 8765 8732 -33
Branches 787 783 -4
==========================================
- Hits 7696 7668 -28
+ Misses 791 789 -2
+ Partials 278 275 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
force-pushed
the
remove_mimic_legacy
branch
from
3bdc081
to
594c39c
Compare
bmagyar
previously approved these changes
Jun 19, 2024
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
destogl
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup from #1256: Removing the deprecated mimic configuration via ros2_control section in the URDF.