New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff drive parameter fixes #145

Merged

bmagyar merged 2 commits into ros-controls:master from pal-robotics-forks:diff-drive-parameter-fixes

Feb 3, 2021

Contributor

v-lopez commented Feb 2, 2021

Recover old speed limiter behavior, if unspecified min defaults to -max
Change cmd_vel_timeout to seconds (double) as ROS1 instead of ms(int)

Victor Lopez added 2 commits

February 2, 2021 23:01


          Recover old speed limiter behavior, if unspecified min defaults to -max

c1070a9


          Change cmd_vel_timeout to seconds (double) as ROS1 instead of ms(int)

3ecc715

bmagyar approved these changes

View reviewed changes

Member

bmagyar left a comment

Thanks. We should strive for parameter parity as much as possible with ROS1.

bmagyar merged commit 59cf934 into ros-controls:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment