Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[diff_drive_controller] Fix missing cmath header in speed_limiter.cpp #148

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

olivier-stasse
Copy link
Contributor

Fix #147

@codecov-io
Copy link

Codecov Report

Merging #148 (93dc895) into master (be3fcc0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   35.52%   35.52%           
=======================================
  Files          24       24           
  Lines        2246     2246           
  Branches     1448     1448           
=======================================
  Hits          798      798           
  Misses        132      132           
  Partials     1316     1316           
Flag Coverage Δ
unittests 35.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ller/test/test_load_forward_command_controller.cpp
...ontrollers/src/joint_group_velocity_controller.cpp
...ory_controller/test/test_trajectory_controller.cpp
...ntroller/test/test_load_joint_state_controller.cpp
...test/test_load_joint_group_velocity_controller.cpp
...nt_state_controller/src/joint_state_controller.cpp
...ers/joint_trajectory_controller/src/trajectory.cpp
...ectory_controller/test/test_trajectory_actions.cpp
..._controllers/src/joint_group_effort_controller.cpp
...ler/test/test_load_joint_trajectory_controller.cpp
... and 38 more

@bmagyar
Copy link
Member

bmagyar commented Feb 7, 2021

Could you please also remove the include you mention on math.h and check if it's still OK? The CI only runs Ubuntu builds

@olivier-stasse
Copy link
Contributor Author

Could you please also remove the include you mention on math.h and check if it's still OK? The CI only runs Ubuntu builds

Done. To make it simpler I changed math.h in cmath in speed_limiter.hpp and removed the inclusion I added in speed_limiter.cpp.
It is compiling on macOS Catalina.

@bmagyar
Copy link
Member

bmagyar commented Feb 7, 2021

perfect, thank you!

@bmagyar bmagyar merged commit a80ce8d into ros-controls:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

speed_limiter is not compiling on macOS Catalina
3 participants