Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable #181

Merged
merged 1 commit into from
May 11, 2021
Merged

Remove unused variable #181

merged 1 commit into from
May 11, 2021

Conversation

Karsten1987
Copy link
Contributor

as per title

workspace/ros2/ros2_control_ws/src/ros-controls/ros2_controllers/joint_state_broadcaster/test/test_joint_state_broadcaster.cpp:326:16: error: unused variable ‘NUM_IFS’ [-Werror=unused-variable]
  326 |   const size_t NUM_IFS = IF_NAMES.size();

as per title

```
workspace/ros2/ros2_control_ws/src/ros-controls/ros2_controllers/joint_state_broadcaster/test/test_joint_state_broadcaster.cpp:326:16: error: unused variable ‘NUM_IFS’ [-Werror=unused-variable]
  326 |   const size_t NUM_IFS = IF_NAMES.size();
```
@codecov-commenter
Copy link

Codecov Report

Merging #181 (b66d541) into master (93ab94b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   34.94%   34.90%   -0.04%     
==========================================
  Files         182       26     -156     
  Lines       16030     2289   -13741     
  Branches    10451     1493    -8958     
==========================================
- Hits         5601      799    -4802     
+ Misses        924      132     -792     
+ Partials     9505     1358    -8147     
Flag Coverage Δ
unittests 34.90% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp
...include/joint_trajectory_controller/trajectory.hpp
...include/joint_trajectory_controller/trajectory.hpp
...ectory_controller/test/test_trajectory_actions.cpp
...nt_state_controller/src/joint_state_controller.cpp
...s/test/test_load_joint_group_effort_controller.cpp
...ontroller/test/test_forward_command_controller.cpp
...lers/test/test_joint_group_velocity_controller.cpp
...lers/test/test_joint_group_position_controller.cpp
..._broadcaster/test/test_joint_state_broadcaster.cpp
... and 198 more

@bmagyar
Copy link
Member

bmagyar commented May 11, 2021

Fixes #180

@bmagyar bmagyar merged commit f04c5a1 into master May 11, 2021
@destogl destogl deleted the Karsten1987-patch-1 branch June 25, 2021 07:38
gwalck pushed a commit to StoglRobotics-forks/ros2_controllers that referenced this pull request Jun 7, 2023
* Added joint_limits_interface - Direct port from ROS 1
* Follow ros2 styles and added tests
* Added missing dependencies in package.xml
* updated joint limits interface exception to nothrow and match base override
* converted joint limit interfaces to use new JointHandles (no more JointStateHandle or JointCommandHandle). Refactored common functionality into base JointSaturationLimitHandle and JointSoftLimitsHandle classes.
* updated joint limits tests to use new JointHandles
* updated package version from 2 to 3
* added memory include as suggested by ros_industrial test
* uncrustify fixes
* removing changelog from ROS1
* Reset version and fix links
* Update maintainers

Co-authored-by: ddengster <ed.fan@osrfoundation.org>
Co-authored-by: ahcorde <ahcorde@gmail.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Colin MacKenzie guru-florida
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants