Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time and period to update function #241

Merged
merged 4 commits into from
Sep 21, 2021

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Sep 18, 2021

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the first port. Do not forget open a follow-up issue where the paramters should be used by the controllers.

Co-authored-by: Victor Lopez <3469405+v-lopez@users.noreply.github.com>
@destogl destogl merged commit 177b174 into ros-controls:master Sep 21, 2021
gwalck pushed a commit to StoglRobotics-forks/ros2_controllers that referenced this pull request Jun 7, 2023
* Use constants instead of strings in tests

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants